Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver - Archive manager for Xfce https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217311 fedora@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://bugzilla.xfce.org/sho | |w_bug.cgi?id=2616 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2006-12-13 19:15 EST ------- (In reply to comment #19) > In the spec file comment, there is > svn co http://svn.xfce.org/svn/goodies/xfce4-websearch-plugin/trunk > xfce4-websearch-plugin Oops, thanks for catching this. > Should the BR be gettext or gettext-devel? Currently it seems > to need some autoconf macros from gettext-devel, but even after > they are not needed anymore isn't gettext-devel needed? Should be gettext for %find_lang. Because this package is a SVN snapshot it also BuildRequires xfce-dev-tools, which have a dependency on gettext-devel (I think you know, because you reviewed it) > APPROVED, with the gettext question answered, and the proper comment > for source generation added. Ok, will do that tomorrow, now I'm going to bed. I promise not to publish this for Core 5/6 until http://bugzilla.xfce.org/show_bug.cgi?id=2616 has been resolved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review