Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver - Archive manager for Xfce https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217311 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pertusus@xxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From pertusus@xxxxxxx 2006-12-13 18:58 EST ------- In the spec file comment, there is svn co http://svn.xfce.org/svn/goodies/xfce4-websearch-plugin/trunk xfce4-websearch-plugin I think it should be svn co -r24096 http://svn.xfce.org/svn/xfce/xarchiver/trunk xarchiver Otherwise * rpmlint gives: W: xarchiver mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) * name is right * follow guidelines * svn snapshot used for good reasons * .desktop file shipped * icons installed scriptlets used correctly * match upstream (verified with a diff) * %files section right needs work: Should the BR be gettext or gettext-devel? Currently it seems to need some autoconf macros from gettext-devel, but even after they are not needed anymore isn't gettext-devel needed? APPROVED, with the gettext question answered, and the proper comment for source generation added. Please, don't push to FC-6 or FC-5 until the security issue has been solved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review