Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596138 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag|needinfo?(notting@xxxxxxxxx |fedora-review? |m) | --- Comment #17 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2011-01-27 12:35:20 EST --- Sorry for the wait; my time is limited and there are very many package review tickets that need attention. Indeed, the 0.3.6 version starts in rawhide and seems to function well enough. I note that there's only the MPL license text included. It's not essential, but generally in that situation I'd ask you to ask upstream to consider adding the other valid license texts as well (GPL and LGPL). Since you're upstream, though, I guess that skips a step. I assume you want to push this to el5, since it appears to have a sufficiently new xulrunner. If not, however, you can remove BuildRoot, %clean and the first line of %install. It is not necessary for you to manually specify a dependency on boost-program-options; rpm finds that out on its own. This needs a .desktop file. http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files * source files match upstream. sha256sum: 907e3b93d17470fc0625376057e6b88ffd5213eea76aa3fb19820c9b03059ee4 nss-gui-0.3.6.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package (though not all license texts are available). * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. X final provides and requires: nss-gui = 0.3.6-1.fc15 nss-gui(x86-64) = 0.3.6-1.fc15 = X boost-program-options (unnecessary) libboost_program_options.so.1.44.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) xulrunner >= 1.9.2.2 * no bundled libraries. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. X This is a GUI application, but the .desktop file is missing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review