Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672986 Rob Crittenden <rcritten@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(rcritten@xxxxxxxx | |om) | --- Comment #2 from Rob Crittenden <rcritten@xxxxxxxxxx> 2011-01-27 12:36:00 EST --- Spec URL: http://rcritten.fedorapeople.org/freeipa.spec SRPM URL: http://rcritten.fedorapeople.org/freeipa-2.0.0-0.2.beta.git442d6ad.fc14.src.rpm For the Obsoletes the way I read the packaging guidelines is if it is not an upgradable package then having just Obsoletes is ok. I went without noreplace on the bash_completion.d script, our update should take priority. The zero-length /etc/ipa/default.conf is our package owns the file. It should have been ghosted but was actually referenced twice in the spec file, once in the server subpackage and once in the python subpackage. I removed the server reference and added ghost to the python subpackage. I added comments about the "dangerous" mv and cp references. They are primarily for maintaining proper state while we load custom SELinux policy. One mv was removed as it is no longer needed. I added the python conditionals, it seems that we could remove this whole block completely since we don't support older versions of RHEL or Fedora. It doesn't hurt anything though. I added a %doc to the server-selinux package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review