Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662258 --- Comment #3 from Andrew McNabb <amcnabb@xxxxxxxxxxx> 2011-01-26 18:37:47 EST --- (In reply to comment #2) > (In reply to comment #1) > > 1) These errors from rpmlint should be fixed if possible: > > > > ghc-pcre-light-prof.x86_64: E: devel-dependency ghc-pcre-light-devel > > ghc-pcre-light-prof.x86_64: W: devel-file-in-non-devel-package > > /usr/lib64/ghc-6.12.3/pcre-light-0.4/libHSpcre-light-0.4_p.a > > Standard Haskell packaging things. These files are used when profiling the code > which implies that the -devel package exist. Shouldn't the libHSpcre-light-0.4_p.a appear in the devel package rather than in the main package? > > 2) There shouldn't be common_summary, common_description, and ghc_pkg_c_deps > > macros since these are only used once. The ghc_pkg_deps line should be removed > > completely because the macro is undefined. > > These are also standard Haskell packaging things. I think the %{common_*} > macros are used in the %{?ghc_lib_package} line which is where the -prof and > -devel subpackages are defined. I don't see any reference to this on the Haskell packaging guidelines page: http://fedoraproject.org/wiki/Packaging/Haskell > > 3) I noticed that there are two options for conditional builds: shared and > > hscolour. Can you confirm that these are desirable? In other words, could you > > add a comment to the spec file describing why someone might choose to use these > > options? > > These are actually no longer there in the latest cabal2spec templates. I'll > update the spec file to it. Sounds great. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review