Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672136 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-24 14:40:59 EST --- Hey thanks for the review / approval. Incorporated your feedback into an updated version SPEC: http://mo.morsi.org/files/rpms/rubygem-multimap.spec SRPM: http://mo.morsi.org/files/rpms/rubygem-multimap-1.1.2-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2740138 (In reply to comment #2) > * Package looks good, rpmlint looks good, passes the review guidelines. > > * Cleaning > - "rm -rf %{buildroot}" at the top of %install, %clean section > are no longer needed: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > Done. > * Splitting out document files > - Please consider to create -doc subpackage and move the following > files / directories into -doc > ---------------------------------------------------- > %doc %{gemdir}/doc/%{gemname}-%{version} > %doc %{geminstdir}/Rakefile > %doc %{geminstdir}/spec > %doc %{geminstdir}/%{gemname}.gemspec > ---------------------------------------------------- > Done. > * Test execution > - Please consider test execution just using "spec spec/" instead of "rake > spec". > This would allow to omit the Rakefile and .gemspec as well as build > dependency on Rake. > Done. > > However, neither of this is blocker: > > APPROVED New Package SCM Request ======================= Package Name: rubygem-multimap Short Description: Ruby multimap implementation Owners: mmorsi Branches: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review