Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=672136 VÃt Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-01-24 06:14:55 EST --- * Package looks good, rpmlint looks good, passes the review guidelines. * Cleaning - "rm -rf %{buildroot}" at the top of %install, %clean section are no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * Splitting out document files - Please consider to create -doc subpackage and move the following files / directories into -doc ---------------------------------------------------- %doc %{gemdir}/doc/%{gemname}-%{version} %doc %{geminstdir}/Rakefile %doc %{geminstdir}/spec %doc %{geminstdir}/%{gemname}.gemspec ---------------------------------------------------- * Test execution - Please consider test execution just using "spec spec/" instead of "rake spec". This would allow to omit the Rakefile and .gemspec as well as build dependency on Rake. However, neither of this is blocker: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review