Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665560 Mohammed Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |646836 --- Comment #9 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2011-01-23 15:35:50 EST --- (In reply to comment #7) > (In reply to comment #6) > Spec URL: http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.14-2.fc14.spec > SRPM URL: http://dl.dropbox.com/u/14118661/rubygem-mail-2.2.14-2.fc14.src.rpm > > Don't make 'rubygem-mail.spec' for reason > koji scratch build: FAIL > http://koji.fedoraproject.org/koji/taskinfo?taskID=2737227 > > (Now http://dl.dropbox.com/u/14118661/rubygem-mail.spec this is > 'rubygem-mail-2.2.14-1.fc14.spec' without %check section) > This is weird. I'm seeing this also, and not sure what the cause is. It seems to only occur when the build target is dist-rawhide, for example I just rebuilt the jnr-netdb package against dist-rawhide (which failed) and dist-f14 (which succeeded) http://koji.fedoraproject.org/koji/taskinfo?taskID=2738420 http://koji.fedoraproject.org/koji/taskinfo?taskID=2738431 I'm not sure if moving the BuildRequies(check) to BuildRequires is the right solution (anyone care to comment on this? mamoru?), but can't find anything in the package guidelines pertaining to BuildRequires(check), so unless there are any contrary opinions/solutions, I'm fine with that fix. > > * passes review guidelines (would be good to get a separate LICENSE file from > > upstream, but is not required) > > > + This fixed. > There isn't LICENSE file at upstream. There is the LICENSE section in README > file. > I separate LICENSE file from the LICENSE section in README file in %prep > section. > This is not what I meant. I merely was suggesting you contact upstream to include the separate LICENSE file as directed here http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Since this is a SHOULD it isn't a blocker for the package being accepted. The fix you added though doesn't seem to work though, at least not for me locally. When I run rpmbuild I get the following error + csplit ./usr/lib/ruby/gems/1.8/gems/mail-2.2.14/README.rdoc '/== License:/' 17683 1087 + /bin/mv -f ./usr/lib/ruby/gems/1.8/gems/mail-2.2.14/xx00 ./usr/lib/ruby/gems/1.8/gems/mail-2.2.14/README.rdoc /bin/mv: cannot stat `./usr/lib/ruby/gems/1.8/gems/mail-2.2.14/xx00': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.fiDfF8 (%prep) This entire bit of extracting the LICENSE out of the readme can probably be removed all together. > > * you can also download the spec suite from the upstream project and run it in > > a %check section if you want > > > - not fixed yet. > Prepare spec suite from the upstream to tarball. > For spec suite need rubygem-bundler - it not packed yet (#646836). > I add %check section. No success yet - koji scratch build: FAIL. > So thanks for doing this.. In addition to bundler the gemspec references several other gems which need to be installed for the spec suite to work. treetop is needed, and was just pushed to rawhide, as well as activesupport, mime-types, i18n, ZenTest, rcov, rspec, diff-lcs, ruby-debug (all of which are in Fedora). Please add these all as BuildRequires dependencies. You will also need to pull https://github.com/mikel/mail/raw/master/Gemfile as a rpm source and add it and Gemfile.lock to the %files section. Additionally the ZenTest dep is too high in the Gemfile, but I've verified that the mail test suite works against the ZenTest version in fedora. You can downgrade it with the following patch $ cat mail-downgrade-gemfile-deps.patch --- Gemfile.orig 2011-01-23 14:25:06.328793651 -0500 +++ Gemfile 2011-01-23 14:28:17.529793736 -0500 @@ -7,7 +7,7 @@ gem "treetop", "~> 1.4.8" gem "i18n", ">= 0.4.0" group :test do - gem "ZenTest", "~> 4.4.0" + gem "ZenTest", ">= 4.3.1" gem "rcov", "~> 0.9.8" gem "rake", "~> 0.8.7" gem "bundler" > build.log: > error: line 42: Unknown tag: BuildRequires(check): rubygem(rake) > > Why 'Unknown tag:'? It is not clear for me. > > Solutions: > 1. Comment %check section. Search solution later. > 2. I need help. Direct me to right way, please. Again I'm not sure whats causing this, and am fine w/ the BuildRequires(check) -> BuildRequires workaround unless there is a better solution. Once the other BuildRequires dependencies listed above are added to the spec and bundler and treetop are installed locally, 'rake spec' in the check section successfully runs. treetop was just pushed to Fedora rawhide. bundler was blocked on thor which has been updated in rawhide, so that should also be coming soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review