Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667155 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2011-01-21 20:56:19 EST --- NEEDSWORK Good: * rpmlint clean * Package follows naming guidelines * Spec file name matches package name * License is MIT in source and spec file * MIT is an open source license * Spec file is legible American English * License is included in the README which is included in the package * Source matches upstream: sha256sum httplib2-0.6.0.tar.gz 58de068e5af5661c566abb871a75133cc8297e6473ff3f15e98079d57da3978c httplib2-0.6.0.tar.gz * Builds in koji * All build deps satisfied but see below; there's some extra ones. * No locale files that need to be marked with %find_lang * No shared libraries * No bundled libraries * Package is not relocatable * No files listed more than once * All files and directories created by the package owned by the package and no others. * Package contains code, not content. * No large documentation that needs to be in a separate subpackage * Nothing in %doc used at runtime * No GUI application included so no .desktop requirement * All filenames are valid utf-8 * No scriptlets * No file dependencies * No programs so no need for man pages Needswork: * Don't need python26-setuptools that I can see * In the %build section, need to either use %{__python} or python2.6 rather than "python" * The library comes with a test suite. You should run it in a %check section. If it needs to be able to contact the public internet you may need to disable those particular tests. If the test suite is just worthless without access to the public internet, please add a comment to the spec file in the %check section that says why the testsuite isn't being run. Cosmetic: * Would be better to name python_sitelib python26_sitelib to avoid ambiguity. * We normaly don't have A, The, or other articles in the summary: Summary: Comprehensive HTTP client library Fix at least the Needswork entries and I can approve the package. You also need to be sponsored it looks like and I am a sponsor. I see that you have some reviews in progress:: https://bugzilla.redhat.com/show_bug.cgi?id=639874 https://bugzilla.redhat.com/show_bug.cgi?id=668591 https://bugzilla.redhat.com/show_bug.cgi?id=670457 Especially since you are seeking sponsorship, your reviews should look more like mine - with a list of all the things you checked and found were good as well as the things that were in need of changing. This helps to show that you've read the packaging guidelines and remember at least the Review Guidelines: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines I'll go ahead and CC myself on those package reviews and when you complete them, I'll sponsor you and you can finish approving them. If you have questions you can reach me via email or (better) on irc.freenode.net -- I'm abadger1999. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review