Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663244 --- Comment #7 from Shakthi Kannan <shakthimaan@xxxxxxxxx> 2011-01-19 18:54:40 EST --- Thanks for your wondeful feedback! - Updated to license LGPLv2+. I checked the COPYING file for LGPLv2 and hence had used it. The code mentions also higher versions. - Changed to use BuildRoot. - Added comments for inclusion of patches. - Removed inconsistent macro usage. - Moved man page, HTML documentation to devel package. - Added AUTHORS, COPYING, README, TODO to doc in base package. - Used * in man, library inclusion. I haven't changed Source0 because I get a 404 error if I use Source0 as: http://downloads.sourceforge.net/%{name}/%{name}-2.1-2-src.tar.bz2 I have pushed the patches upstream for inclusion in the project repo, and retaining it in the .spec file since rpmlint warns about calling exit() function in a library. SPEC: http://shakthimaan.fedorapeople.org/SPECS/CUnit.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/CUnit-2.1_2-4.fc14.src.rpm $ rpmlint CUnit.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint CUnit-2.1_2-4.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint CUnit-devel-2.1_2-4.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Successful Koji builds for F-13, F-14, EL-6 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=2732327 http://koji.fedoraproject.org/koji/taskinfo?taskID=2732331 http://koji.fedoraproject.org/koji/taskinfo?taskID=2732336 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review