[Bug 663244] Review Request: CUnit - A unit testing framework for C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663244

Martin Gieseking <martin.gieseking@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking@xxxxxx

--- Comment #6 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-01-19 06:10:03 EST ---
Hi Shakthi,

here are some notes on your latest spec:

- the license of CUnit is LGPLv2+

- BUILDROOT => BuildRoot

- add short comments above Patch0 and Patch1 telling what the patches do

- Don't change the behavior of the library. If a library calls exit() you 
  should ask upstream to fix it but don't remove the function call with a 
  local patch

- adapt Source0 according to
  http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- you should use macros consistently (don't mix rm and %{__rm} for example)
  I recommend to prefer the plain commands (rm, make etc.) and not to use 
  macros here

- the man3 manpage contains the API docs and thus belongs to the devel package

- the html documentation should also go to the devel package

- add AUTHORS, COPYING, README, TODO to the base package (with %doc)

- replace 
    %{_libdir}/libcunit.so.1
    %{_libdir}/libcunit.so.1.0.1
  with
    %{_libdir}/libcunit.so.*
  to simplify future updates

- replace CUnit.3.gz with CUnit.3*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]