Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670365 Ruediger Landmann <r.landmann@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|NotReady | --- Comment #4 from Ruediger Landmann <r.landmann@xxxxxxxxxx> 2011-01-18 01:07:03 EST --- (In reply to comment #3) > (In reply to comment #2) > > I'll enable these tests. However, it looks like we're not currently shipping > > Test::Fixme, so I'll package that up first before proceeding here. > The distribution tests aren't required for packaging this package for Fedora > (They are checking a package's consistency and not a package's functionality). > I.e. from our POV, they are optional surplus. > > In other words, I'd approve this package with first 2 items from comment #1 > fixed. Thanks Ralf; I've added the missing BuildRequires and cleared the redundant explicit Requires. I've also enabled a couple of the distribution tests and will work on Test::Fixme. Enabling the spelling test resulted in too many errors to allow the package to build, so I've left that disabled. + ./Build test t/01_IO-Any.t ........... ok t/02_IO-Any_AnyEvent.t .. ok t/03_DATA.t ............. ok t/distribution.t ........ ok .... $ rpm -q --requires -p RPMS/noarch/perl-IO-Any-0.04-2.fc14.noarch.rpm perl >= 1:5.010 perl(:MODULE_COMPAT_5.12.2) perl(Carp) perl(Fcntl) perl(File::Spec) perl(IO::AtomicFile) perl(IO::File) perl(IO::String) perl(Scalar::Util) perl(strict) perl(warnings) ... New spec: http://rlandmann.fedorapeople.org/packages/perl-IO-Any.spec New SRPM: http://rlandmann.fedorapeople.org/packages/perl-IO-Any-0.04-2.fc14.src.rpm New rpmlint output: $ rpmlint SPECS/perl-IO-Any.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SRPMS/perl-IO-Any-0.04-2.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/noarch/perl-IO-Any-0.04-2.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. New scratchbuild in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2727809 Cheers Rudi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review