Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=670377 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2011-01-18 00:45:47 EST --- This spec has several issues: * All of your Requires: perl(Test::...) should be BuildRequires: perl(Test::...) These are only used inside of the testsuite and are not Require:'ed by the actual perl module (i.e. the files below lib/) => Please make them BuildRequires. * File-Finder-0.53/t/04-ffr.t depends on perl(File::Find::Rule) => Please add BR: perl(File::Find::Rule). Minor issue: * The source0-URL doesn't work for me: # lftp -c get http://www.cpan.org/modules/by-module/File/File-Finder-0.53.gz get: Access failed: 404 Not Found (/modules/by-module/File/File-Finder-0.53.gz) This is a known issue with cpan's URL redirection, which seems to have problems in providing "by-modules" on mirrors. I'd recommend to use the "by author" URL instead: http://search.cpan.org/CPAN/authors/id/M/ME/MERLYN/File-Finder-0.53.tar.gz Ignorable issue: There seems to be an implicit dependency on File::Find inside of File::Finder::Steps.pm ATM, I am not sure, if this is a strict dependency or if this dependency can be treated optional. For now, this doesn't matter in practice, because perl(File::Find) is provides by the core perl package. => For now this issue can be ignored, IMO. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review