Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=667226 Volker FrÃhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #10 from Volker FrÃhlich <volker27@xxxxxx> 2011-01-15 20:40:22 EST --- You dropped the BuildRequires instead of the Requires for Phonon. Please re-add: BuildRequires: phonon-devel and delete Requires: phonon Please mend that, because otherwise the package won't build. Here is the review. - Package meets naming guidelines - Spec file matches base package name. - Spec has consistent macro usage. - Meets Packaging Guidelines. - License acceptable for Fedora - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: aba7189133005260fcf85046a5f6e80c - BuildRequires correct - Spec handles locales/find_lang - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package is code - Packages %doc files don't affect runtime. - Package is a GUI app and has a .desktop file - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. SHOULD Items: - Functions as described - Has dist tag - Packages latest version The comment should say "Remove all devel libraries ..." not "Remove all non-devel libraries ...". As you don't use a buildroot tag, you can drop the clean section and the rm -rf %{buildroot} in %install. But it doesn't do any harm. Tests MISSING until you revised: - Requires and provides - rpmlint - Package compiles and builds on at least one arch: - Should build on all supported archs -- no buildroot, so it's only Intel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review