Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665544 --- Comment #6 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2011-01-14 03:58:00 EST --- (In reply to comment #5) > The updated spec file removes the dependency on main package. Does the -javadoc > subpackage also need a copy of the license then? Ah, yes. Sorry I didn't mention this in the review. You need to include license in the javadoc subpackage now. I now noticed you include src/main/java/org/ini4j/package.html. We don't normally include this file in the doc as people who want docs install javadoc subpackages. > > [!] If package uses custom depmap "-Dmaven2.jpp.depmap.file=*" explain why > > it's needed in a comment > > Removing activation is OK, but please file a bug for plexus-mail-sender to > > provide correct depmap. I'll work on fixing it in the meantime :-) > > Filed as bug 669495. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review