Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=669311 --- Comment #14 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-01-14 03:18:57 EST --- (In reply to comment #13) > Jussi, > I have NOT mixed %{buildroot} and $RPM_BUILD_ROOT, or %{optflags} and > $RPM_OPT_FLAGS in my packages. I know. (In reply to comment #11) > Jason, I read http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (MUST: > Each package must consistently use macros.). After this I've replaced all my > foo to %{__foo}. Is it wrong? I'll fix if It's It's not wrong, it's just bad style since it makes spec files a lot harder to read (Jason put it aptly in comment #9 ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review