Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560787 --- Comment #9 from Paulo Roma Cavalcanti <promac@xxxxxxxxx> 2011-01-08 19:30:38 EST --- (In reply to comment #8) > A few comments: > > %python_sitearch doesn't seem to be used anywhere; you should remove it if it's > not needed. No problem. > > I don't know what releases you're targeting, but you can remove BuildRoot, the > first line of %install and the %clean section on Fedora and EL6. It works with python 2.4 (RHEL5) too. > > I see no license information at all on either the mtTkinter.py file or the > 08-clock-bezier.py file. Where do you see that those files are under the > Python license? Also, does the latter file not have an upstream? It doesn't > seem like it belongs in the package. > 08-clock-bezier.py is an example written by me. It is the smallest script I could think of where the problem shows up, and it is based on an old tcl script. I did not find any license file for mtTkinter.py, but since it is a modification of tkinter, doesn't it have the same license? > /usr/lib/python2.7/site-packages/mtTkinter.py should not be executable, and > should not have the shebang line you patch onto it. You also should not patch > in copyright information like that. I agree with you. The patch should be removed, because it does not add anything useful. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review