[Bug 666763] Review Request: ax_emergency_listen - monitors APRS emergency packets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666763

--- Comment #10 from Guido Trentalancia <guido@xxxxxxxxxxxxxxxx> 2011-01-04 16:25:46 EST ---
Thanks Jason and thanks Martin for your latest comments and interest !

Jason and Martin: I was using rpmlint version 1.0 and not on Fedora. So
perhaps, it is a warning being triggered only by upstream rpmlint. Let's leave
the issue as it is.

Martin: yes, I do get more or less the same Warnings that you get. More
specifically:

[root@tesla rpmlint-1.0]# python2.6 -O -u rpmlint.py -C .
/home/guido/rpmbuild/SRPMS/ax_emergency_listen-1.3.2-4.src.rpm 
ax_emergency_listen.src: W: spelling-error %description -l en_US startup ->
start up, start-up, starter
ax_emergency_listen.src: W: strange-permission
ax_emergency_listen-1.3.2.tar.bz2 0664
ax_emergency_listen.src: W: strange-permission ax_emergency_listen.spec 0664
ax_emergency_listen.src:93: W: macro-in-%changelog %{_sysconfdir}
ax_emergency_listen.src:66: W: mixed-use-of-spaces-and-tabs (spaces: line 66,
tab: line 1)
1 packages and 0 specfiles checked; 3 errors, 6 warnings.

- Fixed the spelling issue in release 1.3.2-5 that is about to come;
- Don't know what's wrong with permissions set to 664 (or 644) on the source
archive ???
- Fixed the use of macros in changelog (rel 5);
- Fixed the use of spaces (rel 5).


[root@tesla rpmlint-1.0]# python2.6 -O -u rpmlint.py -C .
/home/guido/rpmbuild/SRPMS/ax_emergency_listen-1.3.2-4.src.rpm
/home/guido/rpmbuild/RPMS/i386/ax_emergency_listen-1.3.2-4.fc11.i386.rpm 
ax_emergency_listen.src: W: spelling-error %description -l en_US startup ->
start up, start-up, starter
ax_emergency_listen.src: W: strange-permission
ax_emergency_listen-1.3.2.tar.bz2 0664
ax_emergency_listen.src: W: strange-permission ax_emergency_listen.spec 0664
ax_emergency_listen.src:93: W: macro-in-%changelog %{_sysconfdir}
ax_emergency_listen.src:66: W: mixed-use-of-spaces-and-tabs (spaces: line 66,
tab: line 1)
ax_emergency_listen.i386: W: manpage-not-compressed bz2
/usr/share/man/man1/ax_emergency_listen.1.gz
ax_emergency_listen.i386: W: spelling-error %description -l en_US startup ->
start up, start-up, starter
ax_emergency_listen.i386: W: unstripped-binary-or-object
/usr/bin/ax_emergency_listen
ax_emergency_listen.i386: W: non-conffile-in-etc
/etc/sysconfig/ax_emergency_listen
ax_emergency_listen.i386: W: no-manual-page-for-binary
ax_emergency_listen_helper
ax_emergency_listen.i386: W: missing-lsb-keyword Required-Start in
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: W: missing-lsb-keyword Required-Stop in
/etc/rc.d/init.d/ax_emergency_listen
ax_emergency_listen.i386: W: service-default-enabled
/etc/rc.d/init.d/ax_emergency_listen
2 packages and 0 specfiles checked; 5 errors, 15 warnings.

- Fixed the spelling issue in release 1.3.2-5 that is about to come;
- Don't know what's wrong with permissions set to 664 (or 644) on the source
archive ???
- Fixed the use of macros in changelog (rel 5);
- Fixed the use of spaces (rel 5);
- Why should I strip binaries ? To loose debugging information when at the end
it is compiled with it ?
- What's wrong with the config file being place in /etc/sysconfig (is there a
list of known config files somewhere, that is not listing mine ?) ?
- Fixed the init script with empty Required-Start and Required-Stop; in the
end, the only thing that is required is that the (kiss) interface has been
configured with kissattach or something equivalent to that; it doesn't even
need the network interface to be up (such as ax0);
- It's really pointless to provide a manual page for the daemonizer script (by
the way, do you have any better idea on how to "daemonize" without touching the
source files ?);
- The service is enabled by default, otherwise ? Who decides what is good and
what is bad ? Other packages with init files are doing the same... And if the
user is installing the package there is a very good chance that he/she intends
to use it;
- Manual page not compressed in bzip2 ?? No idea. You don't even have got that,
Martin. Something to do with upstream rpmlint 1.0 that I am using.

Honestly, apart from those warnings that I have already fixed in release 5, I
would say everything is fine, at the end it's only warnings and the Packaging
Guidelines don't even mention about warnings.

However, I remain open to any advice on possible fixes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]