Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666633 --- Comment #4 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2011-01-04 16:15:41 EST --- Thast is now an official review: Good: + Package name fullfill naming guidelines + Package has consistantly rpm macro usage + Package contains URL tag to project homepage + Package contains recent version of the software + License tag contains a valid OSS license + License tag refer GPLv2+ as as valid license + Package contains verbatin copy of the license text + Package has a devel sub package + Source tag shows on proper dowload location + package tar ball matches with upstram one (md5sum: 6f00882c15b8cc703718d22e1b1871f) + local build works fine + Parallel build is supported by the package + debuginfo rpm contains source files + Build on koji (rawhide) works fine + local install und uninstall works fine + All file and directories are owned by the package + There are not naming conflicts with other packages + %doc stanza is small, so we need no separate sub package. + Changelog entries has proper format Please check: ? Rpmlist shows folling warning on source rpm: lastfmlib.src: W: spelling-error Summary(en_US) scrobbling -> scribbling, scrabbling lastfmlib.src: W: spelling-error %description -l en_US scrobble -> scribble, scrabble lastfmlib.src: W: strange-permission lastfmlib-0.4.0.tar.gz 0600L 1 packages and 0 specfiles checked; 0 errors, 3 warnings. ? If you have following the suggestion of Michale Schwend you should remove the reference to Petr Vanek from your Changelog entry Bad: - Rpmlint has the following cmplaints to the binary rpms: rpmlint lastfmlib-0.4.0-1.fc14.x86_64.rpm lastfmlib.x86_64: W: spelling-error Summary(en_US) scrobbling -> scribbling, scrabbling lastfmlib.x86_64: W: spelling-error %description -l en_US scrobble -> scribble, scrabble lastfmlib.x86_64: E: non-standard-dir-perm /usr/share/doc/lastfmlib-0.4.0 0644L lastfmlib.x86_64: E: zero-length /usr/share/doc/lastfmlib-0.4.0/TODO 1 packages and 0 specfiles checked; 2 errors, 2 warnings. Please remove the empty TODO file and change the permissions of the documentation directory because traversal into this directory will be denied for ono-root users -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review