Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 --- Comment #3 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxx> 2011-01-04 12:38:36 EST --- (In reply to comment #2) > - You are mixing %{buildroot} and $RPM_BUILD_ROOT Fixed, replaced by %{buildroot} > - GUI tools should have a desktop file > (https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files) I am not sure if we want to make spicy a featured client just now. Spice-Gtk is rather a library. virt-viewer/virt-manager and hopefully others such as vinagre, have .desktop and will support spice-gtk. So I would rather avoid having a .desktop file for spicy now. > - All documentation files (AUTHORS, README, COPYING, etc) must be added to %doc Added in spice-gtk. > - The latest release 0.3 according your spec file but the SOURCE RPM is 0.1.0 It has been updated since then, please find latest srpm: http://fedorapeople.org/~elmarco/spice-gtk-0.3-1.fc14.src.rpm Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review