Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657403 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-01-04 11:04:46 EST --- Just some quick comments: - You are mixing %{buildroot} and $RPM_BUILD_ROOT - GUI tools should have a desktop file (https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files) - All documentation files (AUTHORS, README, COPYING, etc) must be added to %doc - The latest release 0.3 according your spec file but the SOURCE RPM is 0.1.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review