Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646611 --- Comment #3 from Volker FrÃhlich <volker27@xxxxxx> 2010-12-20 16:30:12 EST --- Please align Requires, URL and the likes. The summary doesn't match upstream's and is not proper English. I personally think it's strange either way: "I can create a field with my browser now?" The description has the same problems and the part about Drupal 4 and 5 is obsolete. I think the version number for "Requires: drupal6" is unnecessary, since drupal6 will only contain version six -- no matter what. "content-module" has no execution permissions, so you can drop the chmod. Copying Source1 does not belong into the build section. Move it to the prep section. The %build section should remain empty here. Maybe delete the text files from the buildroot at the end of the install section. That way you don't have to exclude them in the files section. rm -f %{buildroot}%{drupaldir}/modules/cck/*.txt or %exclude {drupaldir}/modules/cck/*.txt, for the sake of brevity. I must have a look at the obsolete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review