[Bug 659679] Review Request: Sigar - System Information Gatherer And Reporter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=659679

--- Comment #2 from Andrew Beekhof <andrew@xxxxxxxxxxx> 2010-12-16 11:06:11 EST ---
That was lazy of me, I should have run rpmlint myself.

New links:

   http://www.clusterlabs.org/~beekhof/sigar.spec
  
http://www.clusterlabs.org/~beekhof/matahari/fedora-14/SRPMS/sigar-1.6.5-0.1.git833ca18.fc14.src.rpm

New rpmlint output:


[04:54 PM] beekhof@f13 ~/rpmbuild/SOURCES # rpmlint fedora-14/x86_64/sigar-*.5*
../SPECS/sigar.spec
sigar.x86_64: W: spelling-error %description -l en_US uptime -> optime, up
time, up-time
sigar.x86_64: W: spelling-error %description -l en_US logins -> losing, login,
loins

These first two warnings are bogus spelling "errors".

sigar.x86_64: E: invalid-soname /usr/lib64/libsigar.so libsigar.so

Upstream has no concept of SO versioning and I am loathed to invent one.
I'm prepared to work with upstream to get this added, however until that time I
would prefer to leave it unversioned.

sigar.x86_64: W: shared-lib-calls-exit /usr/lib64/libsigar.so exit@xxxxxxxxxxx

The use of exit() appears to be intentional and appropriate.

../SPECS/sigar.spec: W: invalid-url Source0: sigar-1.6.5-833ca18.tbz2

The last refers to the tarball.  Unfortunately we need to use git archives as
the published tarballs do not support cmake and the diff to the last release is
massive.  This and the steps for regenerating the tarball have been included in
the spec file.


3 packages and 1 specfiles checked; 1 errors, 4 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]