[Bug 659679] Review Request: Sigar - System Information Gatherer And Reporter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=659679

--- Comment #1 from Jaroslav Reznik <jreznik@xxxxxxxxxx> 2010-12-03 10:11:26 EST ---
rpmlint output:
rpmlint sigar.spec 
sigar.spec:6: W: non-standard-group Libraries
> not ok
sigar.spec:10: W: macro-in-comment %{name}
sigar.spec:10: W: macro-in-comment %{name}
sigar.spec:10: W: macro-in-comment %{version}
sigar.spec:44: W: macro-in-comment %{name}
sigar.spec:44: W: macro-in-comment %{version}
> ok
sigar.spec: W: invalid-url Source0: sigar-1.6.4.tbz2
> not ok
0 packages and 1 specfiles checked; 0 errors, 7 warnings.

rpmlint ../RPMS/x86_64/sigar-1.6.4-1.fc14.x86_64.rpm 
sigar.x86_64: W: name-repeated-in-summary C SIGAR
> ok
sigar.x86_64: W: spelling-error %description -l en_US uptime -> optime, up
time, up-time
sigar.x86_64: W: spelling-error %description -l en_US logins -> losing, login,
loins
> ok
sigar.x86_64: W: non-standard-group Libraries
sigar.x86_64: W: incoherent-version-in-changelog 1.6.0-1 ['1.6.4-1.fc14',
'1.6.4-1']
> please fix
sigar.x86_64: E: invalid-soname /usr/lib64/libsigar.so libsigar.so
> unversioned library
sigar.x86_64: W: shared-lib-calls-exit /usr/lib64/libsigar.so exit@xxxxxxxxxxx
> should be fixed
1 packages and 0 specfiles checked; 1 errors, 6 warnings.

Name: ok
Version & release: ok
Summary: ok
Group: not ok - should be "System Environment/Libraries"
License: ok, ASL 2.0
URL: ok (redirects to http://support.hyperic.com/display/SIGAR/Home)
Source: not ok
Source MD5: can't check - no 1.6.4 binaries at provided URL

Consistent usage of macros: ok
Buildroot: ok (not required anymore but Sigar should go to older releases too)

Devel subpackage: ok
Non-devel subpackage contains .so: yes, shared lib should be properly
versioned, .so symlink should go to -devel subpackage!!!
ldconfig snippet: not ok, missing
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries

Documentation: missing LICENSE NOTICE AUTHORS from upstreams tarball - please
fix at least LICENSE - the must item

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]