Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609295 --- Comment #5 from BJ Dierkes <wdierkes@xxxxxxxxxxxxx> 2010-12-14 19:02:18 EST --- Thank you for your feedback. I can agree with the use of 'real_name' making things more cluttered. I've cleaned that up. I've also removed --single-version-externally-managed. As for the use of %{python} this was done to make porting to other python stacks easier. Rather than changing all references of 'python' to 'python3' or what-have-you, I can simply change the python macro. As for %{pyver}, using wild cards in the files list for 'egg-info' seems it would be less efficient... again when considering that this package may very well be ported to another python stack (via side-by-side python installs, etc).... where pyver might be 2.6 or 3.1 depending on the stack. I don't see any reason to change that at this point. That said the updated files are at: SPEC: http://5dollarwhitebox.org/tmp/python-cement.spec SRPM: http://5dollarwhitebox.org/tmp/python-cement-0.8.14-2.fc14.src.rpm $ rpmlint -i SPECS/python-cement.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint -i RPMS/noarch/python-cement-* python-cement-devtools.noarch: E: zero-length /usr/lib/python2.7/site-packages/cement/paste/templates/cementapp/LICENSE python-cement-devtools.noarch: E: zero-length /usr/lib/python2.7/site-packages/cement/paste/templates/cementplugin/LICENSE 3 packages and 0 specfiles checked; 2 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review