[Bug 634909] Review Request: v8 - JavaScript Engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634909

--- Comment #21 from Alex Hudson (Fedora Address) <fedora@xxxxxxxxxxxxxx> 2010-12-13 10:39:26 EST ---
Sorry to be the bearer of bad news! There's still one existing problem, and I
think I've found a new one :(

There is still a perms issue in -debuginfo:

$ rpmlint RPMS/x86_64/v8-debuginfo-3.0.0.1-1.fc14.x86_64.rpm 
v8-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/v8-3.0.0.1/src/compiler.cc
v8-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/v8-3.0.0.1/src/scanner.cc
1 packages and 0 specfiles checked; 2 errors, 0 warnings.

Looking at the .spec, I think you'd need to add another -print0 before the -o
in order to get the desired effect, this is probably shorter though:

  find -regex '.*\.\(cc\|h\)' -exec chmod -x {} \;

However, there is a new issue as well. I'm sorry I didn't pick this up before,
but I rechecked the licensing with the new 3.0 source package and I think I've
found a problem. These files:

  benchmarks/earley-boyer.js
  benchmarks/raytrace.js

... are not copyright the V8 project and don't have any apparent license with
them. I think this renders them non-distributable in the source even though
they're not included in the binaries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]