[Bug 634909] Review Request: v8 - JavaScript Engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634909

--- Comment #20 from Lubomir Rintel <lkundrak@xxxxx> 2010-12-11 13:24:53 EST ---
(In reply to comment #18)
> There's still a permissions problem in debuginfo:
> 
> $ rpmlint RPMS/x86_64/v8-debuginfo-2.5.9-2.fc14.x86_64.rpm 
> v8-debuginfo.x86_64: W: spurious-executable-perm
> /usr/src/debug/v8-2.5.9/include/v8-debug.h
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fixed.

> One minor comment/question:  is there a reason you're pulling from trunk?
> I would normally expect a tagged pull, e.g. 
> 
>   # svn export http://v8.googlecode.com/svn/tags/2.5.9/ v8-2.5.9
>   # tar czf v8-2.5.9.tar.gz v8-2.5.9

If I recall correctly they did not use to tag releases. They seem to do so now
though, so I changed the source to tags/ as you have proposed.

SPEC: http://v3.sk/~lkundrak/SPECS/v8.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/v8-3.0.0.1-1.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]