Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scipy - array processing for numbers, strings, records, and objects. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218195 ------- Additional Comments From jamatos@xxxxxxxx 2006-12-03 15:33 EST ------- Review for release 2: * RPM name is OK * Source scipy-0.5.1.tar.gz is the same as upstream * Builds fine in mock * File list looks OK * License is correct and acceptable (BSD) * Spec file is written in American English Needs work: * The BuildRoot must be cleaned at the beginning of %install * rpmlint: W: scipy summary-ended-with-dot Scipy: array processing for numbers, strings, records, and objects. Please remove the final dot from Summary There are lots of devel-file-in-non-devel-package warnings, why not to put this into a subpackage -devel? OTHO since numpy does not have this separation this is not a blocker, I think that this issue should be tackled in both packages at the same time. One other question: Why do you use fftw2 and not fftw version 3? Just curious. Summary, if you fix the cleaning of %install this package is approved. No need to submit a new version I trust you to fix this before importing. APPROVED (with due conditions met, this not is here just for an easier reference) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review