Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652412 --- Comment #4 from Marek Goldmann <mgoldman@xxxxxxxxxx> 2010-11-29 05:24:40 EST --- (In reply to comment #2) > 2 issues > > ! Sources > - The gem file in your srpm does not match what I could download > from the URL written in your spec. Looks like after 0.0.4 gem was > uploaded to rubygems.org, you modified gem file locally. Fixed :) > * Usability > - It seems that "boxgrinder-build-local-delivery-plugin" cannot > be loaded directly: > ---------------------------------------------------- > $ irb > irb(main):001:0> require "rubygems" > => true > irb(main):002:0> require "boxgrinder-build-local-delivery-plugin" > NoMethodError: undefined method `plugin' for main:Object > from > /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-local-delivery-plugin-0.0.4/lib/boxgrinder-build-local-delivery-plugin.rb:21 > from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in > `gem_original_require' > from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' > from (irb):2 > irb(main):003:0> > ---------------------------------------------------- > As this script seems the "main" script for this gem, I think > this should be fixed. Perhaps this script should have requirement for > "boxgrinder-build/managers/plugin-manager" > > ---------------------------------------------------- > $ irb > irb(main):001:0> require "rubygems" > => true > irb(main):002:0> require "boxgrinder-build/managers/plugin-manager" > => true > irb(main):003:0> require "boxgrinder-build-local-delivery-plugin" > => true > irb(main):004:0> > ---------------------------------------------------- True, this should work with requiring directly the main require, although it's not usable without the full BG stack. Same goes to all other plugins, will add there require too: [goldmann@work git]$ irb irb(main):001:0> require 'rubygems' => true irb(main):002:0> require 'boxgrinder-build-local-delivery-plugin' => true irb(main):003:0> Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-local-delivery-plugin-0.0.5-1.fc15.src.rpm Changelog: * Mon Nov 29 2010 <mgoldman@xxxxxxxxxx> - 0.0.5-1 - Upstream release: 0.0.5 - [BGBUILD-105] No plugin-manager require for local delivery plugin Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2631639 Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review