Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652412 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-11-27 15:38:39 EST --- 2 issues ! Sources - The gem file in your srpm does not match what I could download from the URL written in your spec. Looks like after 0.0.4 gem was uploaded to rubygems.org, you modified gem file locally. * Usability - It seems that "boxgrinder-build-local-delivery-plugin" cannot be loaded directly: ---------------------------------------------------- $ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "boxgrinder-build-local-delivery-plugin" NoMethodError: undefined method `plugin' for main:Object from /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-local-delivery-plugin-0.0.4/lib/boxgrinder-build-local-delivery-plugin.rb:21 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 irb(main):003:0> ---------------------------------------------------- As this script seems the "main" script for this gem, I think this should be fixed. Perhaps this script should have requirement for "boxgrinder-build/managers/plugin-manager" ---------------------------------------------------- $ irb irb(main):001:0> require "rubygems" => true irb(main):002:0> require "boxgrinder-build/managers/plugin-manager" => true irb(main):003:0> require "boxgrinder-build-local-delivery-plugin" => true irb(main):004:0> ---------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review