Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652403 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-11-26 12:49:42 EST --- Some notes: ! Source --------------------------------------------------------------- a440ee244f272cfa1a2ef680b8beb199 Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem e6d7d2503e9655bb36f73a1ff881cea4 rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem --------------------------------------------------------------- - The source in your srpm does not match the one I could download from the URL written as Source0. Would you explain why? ! No longer needed stuff - %clean section is no longer needed on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * rpmlint issue --------------------------------------------------------------- rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init 0664L /bin/sh --------------------------------------------------------------- - This warning comes because this script does not have executable permission while the script has shebang. While I think this script need not have executable permission because this file seems something like a template, however I think 0644 permission is more proper. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review