Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652403 --- Comment #5 from Marek Goldmann <mgoldman@xxxxxxxxxx> 2010-11-26 13:03:32 EST --- (In reply to comment #3) > Some notes: > > ! Source > --------------------------------------------------------------- > a440ee244f272cfa1a2ef680b8beb199 > Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem > e6d7d2503e9655bb36f73a1ff881cea4 > rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem > --------------------------------------------------------------- > - The source in your srpm does not match the one I could download > from the URL written as Source0. Would you explain why? The src.rpm uses a regenerated gem, but from the same source as pushed to rubygems.org. When checking into git I'm overriding the .gem with the proper version (from rubygems.org). Currently - all my src.rpm have this issue. I'll change the way I build my src.rpm for review for the next submissions. Sorry for confusion! > ! No longer needed stuff > - %clean section is no longer needed on Fedora: > https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean Going to remove it, thanks! > * rpmlint issue > --------------------------------------------------------------- > rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script > /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init > 0664L /bin/sh > --------------------------------------------------------------- > - This warning comes because this script does not have executable permission > while the script has shebang. While I think this script need not have > executable > permission because this file seems something like a template, however I > think > 0644 permission is more proper. Yes this is just a template. I'll post updated spec and review your package shortly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review