Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655599 --- Comment #5 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-11-25 13:16:10 EST --- (In reply to comment #3) > Mostly this package seems ok, but there are some spelling errors, so will have > a closer look, when that is fixed: What spelling errors? My spell checker didn't find any. > - %{name} is remmina-pluginS (with 's' at the end), but most subpackages don't > have that 's'. > It would be better to be consistend with 's' at the end. The packages only contain one plugin each, this is why I used singular plugin instead of plugins. The packages ending with s will not show up in comps (but be pulled in through dependencies), so it is consistent to the user. > That's because you require %{name}-plugins where %{name} already contains the > "plugins". Ouch, my bad. I will fix provide a new package once we agreed on the naming. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review