Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554103 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #16 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-21 04:13:35 EST --- Hi, Full review done: Good: - rpmlint checks return: fgrun.x86_64: W: dangling-relative-symlink /usr/bin/fgrun-wrapper opengl-game-wrapper.sh fgrun.x86_64: W: no-manual-page-for-binary fgrun fgrun.x86_64: W: no-manual-page-for-binary fgrun-wrapper 3 packages and 0 specfiles checked; 0 errors, 3 warnings. These can all be ignored. - package meets naming guidelines - license (GPLv2+ and CC-BY-SA) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file as needed and correctly installed Needs work: - Is missing a "Requires: hicolor-icon-theme" (for /usr/share/icons/hicolor dir hierarchy ownership). - Icon cache update scripts are of the old variant, see: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache For the new style - .desktop file: - contains obsolete: "Encoding=UTF-8" (remove please) - "Icon=fgrun.png" should be "Icon=fgrun", esp. as the package also ships an svg - %files contains: "%defattr(-,root,root)" please use "%defattr(-,root,root.-)" instead Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review