Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639263 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-11-20 09:16:20 EST --- Thanks! (In reply to comment #3) > Full review done, results below: > Bad (MUST FIX): > - Spec file states license is BSD, copyright headers in the source code contain > MIT headers -> change spec file to match Done. > - License text included in the upstream sources is Apache -> do not include > as %doc (as its wrong), mail upstream about this Removed. Will send message upstream asap. > - source do no match upstream, doing spectool -g erlang-rebar.spec yields > a different tarbal then in the source rpm -> include a tarbal generation > script as Source2, make this script check out a specific revision. Done. The project was relocated to GitHub, and I changed all links accordingly. > Remarks (Could FIX): > - The %files contains: > %dir %{_libdir}/erlang/lib/%{realname}-%{version} > %dir %{_libdir}/erlang/lib/%{realname}-%{version}/ebin > %dir %{_libdir}/erlang/lib/%{realname}-%{version}/include > %dir %{_libdir}/erlang/lib/%{realname}-%{version}/priv > %{_libdir}/erlang/lib/%{realname}-%{version}/ebin/%{realname}.app > %{_libdir}/erlang/lib/%{realname}-%{version}/ebin/*.beam > %{_libdir}/erlang/lib/%{realname}-%{version}/include/*.hrl > %{_libdir}/erlang/lib/%{realname}-%{version}/priv/* > This could simply be written as: > %{_libdir}/erlang/lib/%{realname}-%{version} > rpmbuild will then cause the build rpm to own that dir and include (and own) > all dirs and files under it. Done. I also removed two bundled libraries (already packaged separately) and changed versioning to reflect that it's a post-release tarball: http://peter.fedorapeople.org/erlang-rebar.spec http://peter.fedorapeople.org/erlang-rebar-2-2.20101120git90058c7.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review