Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639263 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-20 08:10:05 EST --- Full review done, results below: Good: - rpmlint checks return: See Comment #0 - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Bad (MUST FIX): - Spec file states license is BSD, copyright headers in the source code contain MIT headers -> change spec file to match - License text included in the upstream sources is Apache -> do not include as %doc (as its wrong), mail upstream about this - source do no match upstream, doing spectool -g erlang-rebar.spec yields a different tarbal then in the source rpm -> include a tarbal generation script as Source2, make this script check out a specific revision. Remarks (Could FIX): - The %files contains: %dir %{_libdir}/erlang/lib/%{realname}-%{version} %dir %{_libdir}/erlang/lib/%{realname}-%{version}/ebin %dir %{_libdir}/erlang/lib/%{realname}-%{version}/include %dir %{_libdir}/erlang/lib/%{realname}-%{version}/priv %{_libdir}/erlang/lib/%{realname}-%{version}/ebin/%{realname}.app %{_libdir}/erlang/lib/%{realname}-%{version}/ebin/*.beam %{_libdir}/erlang/lib/%{realname}-%{version}/include/*.hrl %{_libdir}/erlang/lib/%{realname}-%{version}/priv/* This could simply be written as: %{_libdir}/erlang/lib/%{realname}-%{version} rpmbuild will then cause the build rpm to own that dir and include (and own) all dirs and files under it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review