Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498873 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #17 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-11-19 18:44:25 EST --- OK, this builds and installs fine. This is going to be somewhat arduous as this touches most of the packaging guidelines we have. I think I'll take it piece by piece and I won't try to do it all at once, because I know my browser will crash or my power will go out and I'll lose the whole thing. First let's look at rpmlint: thrift.x86_64: W: no-manual-page-for-binary thrift It's nice to have manpages for things when possible but it's not essential. thrift-erlang.x86_64: W: only-non-binary-in-usr-lib This is pretty normal for erlang packages. thrift-cpp.x86_64: W: shared-lib-calls-exit /usr/lib64/libthriftnb.so.0.0.0 exit@xxxxxxxxxxx Generally it's a bad idea for libraries to call exit themselves, but this is something to be reported upstream, not fixed in Fedora packages. thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 _ZN6apache6thrift12GlobalOutputE thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 inflateEnd thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 deflate thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 deflateInit_ thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 inflate thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 deflateEnd thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftz.so.0.0.0 inflateInit_ thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZN6apache6thrift12GlobalOutputE thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZTVN6apache6thrift9transport13TMemoryBufferE thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZN6apache6thrift7TOutput6printfEPKcz thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_get_version thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_set thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_base_free thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZN6apache6thrift9transport13TMemoryBuffer10wroteBytesEj thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_get_method thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_del thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_add thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_init thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_base_set thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 event_base_loop thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZN6apache6thrift7TOutput6perrorEPKci thrift-cpp.x86_64: W: undefined-non-weak-symbol /usr/lib64/libthriftnb.so.0.0.0 _ZN6apache6thrift9transport13TMemoryBuffer14ensureCanWriteEj I know nothing of how these libraries are supposed to be used, but this forces whatever uses these libraries to also link with whatever provides these symbols even if the app doesn't call anything in that library. thrift-cpp.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libthriftz.so.0.0.0 /lib64/librt.so.1 thrift-cpp.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libthriftz.so.0.0.0 /lib64/libm.so.6 thrift-cpp.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libthrift.so.0.0.0 /lib64/libm.so.6 thrift-cpp.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libthriftnb.so.0.0.0 /lib64/librt.so.1 thrift-cpp.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libthriftnb.so.0.0.0 /lib64/libm.so.6 This is just things being linked against libraries that aren't actually called. Not a big problem as long as those libraries would be in memory anyway. So, nothing there that really must be fixed, although the undefined-non-weak-symbol stuff could probably be patched without too much effort. I'll run through my checklist in a bit. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review