Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638590 --- Comment #8 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-11-19 09:27:59 EST --- Hmm, right now it fails to build in mock/rawhide with: build: [echo] Plugin plugins/help. [javac] Compiling 1 source file to /builddir/build/BUILD/bin/classes build: [echo] Plugin plugins/script. [javac] Compiling 6 source files to /builddir/build/BUILD/bin/classes [javac] Note: /builddir/build/BUILD/freemind/plugins/script/ScriptingSecurityManager.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. build: [echo] Plugin plugins/svg. [javac] Compiling 3 source files to /builddir/build/BUILD/bin/classes [javac] /builddir/build/BUILD/freemind/plugins/svg/ExportPdf.java:76: cannot access org.apache.avalon.framework.configuration.Configurable [javac] class file for org.apache.avalon.framework.configuration.Configurable not found [javac] pdfTranscoder.addTranscodingHint(PDFTranscoder.KEY_MAX_HEIGHT, new Float(19200)); [javac] ^ [javac] 1 error BUILD FAILED /builddir/build/BUILD/freemind/build.xml:162: The following error occurred while executing this line: /builddir/build/BUILD/freemind/plugins/build.xml:33: The following error occurred while executing this line: /builddir/build/BUILD/freemind/plugins/build.xml:17: The following error occurred while executing this line: /builddir/build/BUILD/freemind/plugins/build_import.xml:10: Compile failed; see the compiler error output for details. Total time: 20 seconds In the meantime...there are new packaging guidelines, so no need for %clean section and rm -rf at the beginning of %install section. Also the jar files in %{_javadir} no longer need -%{version} in filename (so just install jar as unversioned). Same thing for javadoc directory. One more suggestion (not needed, just thought to mention this): When you are converting icons, it might be good idea to do it in a "for" cycle over "16 32 48" :-) I'd say if this was building right now I'd probably give you a + right away. Nice packaging considering how big freemind is and how many BRs it has. I really like that you commented on reasons for symlinking and basically any non-standard thing you had to do in the spec file. When you fix the build, I'll do the official review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review