[Bug 650604] Review Request: perl-PDF-Haru - Perl interface to Haru Free PDF Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=650604

--- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2010-11-19 09:15:43 EST ---
(In reply to comment #1)
> FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in standalone
> package in the future (lib/PDF/Haru.pm:8,
> http://search.cpan.org/~ferreira/Exporter/).
> 
> FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in standalone
> package in the future (lib/PDF/Haru.pm:9,
> http://search.cpan.org/~smueller/AutoLoader/).
> 
> FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in standalone
> package in the future (lib/PDF/Haru.pm:172,
> http://search.cpan.org/~saper/XSLoader/).
> 
> FIX: BuildRequire perl(constant) explicitly as it can dual-live in standalone
> package in the future (lib/PDF/Haru.pm:177,
> http://search.cpan.org/~saper/constant/).
All will be fixed.

> $ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-1.fc14.src.rpm
> ../RPMS/x86_64/perl-PDF-Haru-1.00-1.fc14.x86_64.rpm 
> perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings ->
> encoding, encoding s, encodes
> perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings ->
> encoding, encoding s, encodes
> perl-PDF-Haru.x86_64: W: spurious-executable-perm
> /usr/share/doc/perl-PDF-Haru-1.00/examples/jpeg_demo.pl
> perl-PDF-Haru.x86_64: W: spurious-executable-perm
> /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo.pl
> perl-PDF-Haru.x86_64: W: spurious-executable-perm
> /usr/share/doc/perl-PDF-Haru-1.00/examples/text_demo2.pl
> perl-PDF-Haru.x86_64: W: spurious-executable-perm
> /usr/share/doc/perl-PDF-Haru-1.00/examples/line_demo.pl
> 2 packages and 1 specfiles checked; 0 errors, 6 warnings.
> 
> FIX: Remove executable bit from examples/* files (put chmod into %prep
> section).
Is this necessary? Any guideline? The example scripts are intended to be
executable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]