Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487281 --- Comment #16 from Ruediger Landmann <r.landmann@xxxxxxxxxx> 2010-11-18 23:38:29 EST --- (In reply to comment #13) > > * Unless you're planning to release this for EPEL, you don't need: > > - the BuildRoot tag > > - to clean the BuildRoot in %install > > - the %clean section > Why not?? Off course I plan maintain it also for el5 and el6 branches. OK -- if you plan to maintain for EL5 you still need these items. > > * Neither egw_pear nor eGroupware-egw-pear were ever packaged for Fedora, > > so I don't think we need the Obsoletes (nor the corresponding Provides). > It was usefull in my own repository to migrate versions. In Fedora it is not > needed. Deleted. Thanks; so we probably don't need: Provides: egw-pear = %{version} Provides: egw_pear = %{version} Similarly, I guess we don't need: Provides: egw-core = %{version} Provides: egw-etemplate = %{version} Provides: %{name}-etemplate = %{version} for the core package, right? > I'll be happy if you fix erroÐs in my poor English (from mentioned above in > English only "available" error fixed). Thank you. Patch attached. > > * You already discussed the zero-length files when you opened this > > request. Perhaps use something like "find -size 0" to detect and remove > > the empty files. If these languages are added later, we will no longer > > remove them, but we will also remove any other empty language files > > added in future. Refer to > > http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files > > Off course I known how delete zero length files. And it may be done for example > with these .lang files (about .html speech below). But in case I do not wand > delete all such files it may be done only manually file by file. And what kind > of profit we can get from this? I now suggest deleting only the zero-length language files, which are all together in this directory. (See below for HTML; I agree with you that HTML is not a problem). These empty language files serve absolutely no purpose and only add useless cruft to the installation. > > * Are all these empty index.html files are needed for anything? (perhaps > > to avoid 404 errors?) If they're not needed, please filter them out. > > No, not for avoid 404 errors. Such files placed there as common case workaround > disable directory listing. It off course may be done via -OPTIONS flag in > .htaccess file, but will work only for Apache web server. Also when it is > misconfigured and .htaccess is not work by some reasons - if such index file > present it will be shown. Off course only for rpmlint I can fill its by some > content like '<html><head></head><body></body></html>' (as I can understand it > common sense), but again, if it was not done by upstream developer, for what??? OK; it seems reasonable to leave these in place; and I don't see any advantage in adding content to them. No problem here. All that aside, unfortunately the SRPM you posted in comment #14 doesn't build: http://koji.fedoraproject.org/koji/getfile?taskID=2610482&name=build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review