Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583105 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-11-18 23:13:45 EST --- Sorry nobody has looked at this in ages. I'm trying to go through all of the old tickets. This builds OK; rpmlint just complaints about the lack of a manpage. While it would be useful, it's not mandatory. Some would argue that you should preserve the timestamps when you call iconv. (You do this with touch -r.) It would be nice but it's not essential. It appears that everything is properly built so that the system libupnp and talloc libraries are used instead of the bundled copies. The bundled gnulib library has already been granted a blanket exception from the bundled library policy. There's no way at all that I can test this. * source files match upstream. sha256sum: aa5bb482af4cbd42695a7e396043d47b53d075ac2f6aa18a8f8e11383c030e4f djmount-0.71.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: djmount = 0.71-1.fc15 djmount(x86-64) = 0.71-1.fc15 = libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.5)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libixml.so.2()(64bit) libtalloc.so.2()(64bit) libthreadutil.so.2()(64bit) libupnp.so.3()(64bit) * bundled library is acceptable. * no shared libraries are added to the regular linker search paths. * owns the directory it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review