Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dwmw2@xxxxxxxxxxxxx Component|Package Review |0xFFFF --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2010-11-17 11:02:45 EST --- Thanks for the comments. License changed to GPL22+ (In reply to comment #3) > (In reply to comment #2) > > - I think the description maybe a bit problematic. The Packaging Guidelines > > state that a phrasing like "a program like ..." should be avoided since people > > might understand you wrong (or might _want_ to understand you wrong) when it > > comes to trademarks. > > I agree -- a more detailed description would be nice. Without further > investigation, I don't really understand what the program does. Ok, mention of Punto switcher removed. In summary added name of package to what frontend intended. (In reply to comment #4) > After having a closer look at the package I would like to point out the > following things: > - The files TODO and README are included in the package. However, they are > empty (already in the source tarball). I see no point in including these > files then. Maybe you can ask upstream if this is a mistake. It may be filled in further releases. > - If you update the version of the software you should reset the release number to 1 Is it required? I prefer enumerate releases through all updates. > - As far as I can tell it is not necessary to require xneur, this dependency is > found automagically during the build process. No, versioned demendency is not pulled, please see: $ rpm -qp --requires 'http://koji.fedoraproject.org/koji/getfile?taskID=2606337&name=gxneur-0.10.0-2.fc15.i686.rpm' It depend only from libxnconfig.so.10 and libxneur.so.10, but I require also exactly the same version. > - The icon tag in the .desktop file should not have an explicit file extension > (.png here) Fixed. > Furthermore, Martin (from comment #3) hinted me at the following points: > - the autotools (autoconf, automake, autoheader, libtool, ...) are only needed > when existing configure.ac or Makefile.am files are changed. This is not the > case here and so they don't have to be included. Removed. > - It would be better to be more precise in the %file section. Excessive > globbing might lead to unwanted files being packaged. So it would be better to > make the following changes: > %{_bindir}/* => %{_bindir}/gxneur > %{_mandir}/man?/* => %{_mandir}/man1/gxneur.1* Ok. Additionally add BR GConf2-devel to build in rawhide. http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur-0.10.0-3.fc13.src.rpm http://hubbitus.net.ru/rpm/Fedora13/gxneur/gxneur.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review