Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623606 --- Comment #4 from Golo Fuchert <packages@xxxxxxxxxx> 2010-11-16 16:23:47 EST --- After having a closer look at the package I would like to point out the following things: - The files TODO and README are included in the package. However, they are empty (already in the source tarball). I see no point in including these files then. Maybe you can ask upstream if this is a mistake. - If you update the version of the software you should reset the release number to 1 - As far as I can tell it is not necessary to require xneur, this dependency is found automagically during the build process. - The icon tag in the .desktop file should not have an explicit file extension (.png here) Furthermore, Martin (from comment #3) hinted me at the following points: - the autotools (autoconf, automake, autoheader, libtool, ...) are only needed when existing configure.ac or Makefile.am files are changed. This is not the case here and so they don't have to be included. - It would be better to be more precise in the %file section. Excessive globbing might lead to unwanted files being packaged. So it would be better to make the following changes: %{_bindir}/* => %{_bindir}/gxneur %{_mandir}/man?/* => %{_mandir}/man1/gxneur.1* -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review