Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652544 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-11-15 05:42:19 EST --- (In reply to comment #1) > === Issues === > 1. Upstream has no license file included. Because you are also upstream, please > choose a license from the ones acceptable in Fedora, include the license file > in the source archive, and then package it in %doc. > http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Done. > You are also very welcome to include a README file stating the purpose of the > project and the chosen license. Added README too. > 2. This package must "Requires: rpm" also because it uses its > directories. I added dependency on rpm-build because this package is almost useless for any other needs than building. Also I added dependency on vesrion >= 4.7 because of particular macros used. > 3. Files in %{_sysconfdir} must be marked %config or %config(noreplace). Done. Marked as %config. > 4. This package conflicts with erlang. I'm sure it won't be the case once > imported. So this can be safely ignored. Yes, it's intentional - the original goal was to move off these scripts from erlang into their own independent package. http://peter.fedorapeople.org/erlang-rpm-macros.spec http://peter.fedorapeople.org/erlang-rpm-macros-0.1.2-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review