Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wdm - WINGs Display Manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211433 ------- Additional Comments From pertusus@xxxxxxx 2006-11-29 13:09 EST ------- (In reply to comment #10) > are these files which rpmlint complains as > 'executable-marked-as-config-file' are 'configuration' files? > I feel like that configuration for wdm should done by somewhat > other files if these files should be customizable. In fact they may be in other place than /etc since the script location is set in /etc/wdm/wdm-config. However it could be possible for a sysadm to want to modify them to do special things at login or logout. They are clearly not suitable for %_bindir, but maybe some below /usr/share/, others in %docs. I removed the noreplace flag for the scripts and examples not used in the default case. Now rpmlint is even more verbose. It wouldn't be possible to shut down rpmlint completly with files in /etc, since there would still be W: xorg-x11-xdm non-conffile-in-etc /etc/X11/xdm/Xaccess I don't have a clear idea on what would be the best packaging, but in any case this should be also discussed with xorg-x11-xdm/gdm/kdm > Umm, does /usr/bin/wdmReconfig correctly fix "@SHELL_LOGIN@" > in /etc/wdm/Xclients.in? No, there is a bug in wdmReconf, patched now. > - For install, use 'install -p'. > - Please try to keep timestamps on image files under > /usr/share/pixmaps/wdm . hopefully fixed. > B. Other notes: > * /etc/pam.d/wdm > - This includes > ------------------------------------------- > account include system-auth > ------------------------------------------- > For this pam setting, I usually recommend > 'Requires: pam >= 0.80'. Done, thanks. http://www.environnement.ens.fr/perso/dumas/fc-srpms/wdm-1.28-6.src.rpm - fix reconfiguration script - requires pam recent enough - don't set noreplace for scripts and example config files -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review