Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wdm - WINGs Display Manager https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211433 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-29 11:51 EST ------- Well, then my next question is: A-1 : ------------------------------------------------ E: wdm executable-marked-as-config-file /etc/wdm/Xsession E: wdm executable-marked-as-config-file /etc/wdm/Xsetup_0.wdm E: wdm executable-marked-as-config-file /etc/wdm/Xclients E: wdm executable-marked-as-config-file /etc/wdm/TakeConsole.wdm E: wdm executable-marked-as-config-file /etc/wdm/GiveConsole.wdm E: wdm executable-marked-as-config-file /etc/wdm/Xsession.wdm ------------------------------------------------ are these files which rpmlint complains as 'executable-marked-as-config-file' are 'configuration' files? I feel like that configuration for wdm should done by somewhat other files if these files should be customizable. A-2: ---------------------------------------------------- E: wdm wrong-script-interpreter /etc/wdm/Xclients.in "@SHELL_LOGIN@" E: wdm non-executable-script /etc/wdm/Xclients.in 0644 used by wdmReconfig to regenerate Xclients. ---------------------------------------------------- Umm, does /usr/bin/wdmReconfig correctly fix "@SHELL_LOGIN@" in /etc/wdm/Xclients.in? ---------------------------------------------------- [root@localhost i386]# grep 'SHELL_LOGIN' `rpm -ql wdm` /etc/wdm/Xclients.in:#!@SHELL_LOGIN@ ---------------------------------------------------- For packaging issue (not checked in detail) A. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Timestamps - For install, use 'install -p'. - Please try to keep timestamps on image files under /usr/share/pixmaps/wdm . B. Other notes: * /etc/pam.d/wdm - This includes ------------------------------------------- account include system-auth ------------------------------------------- For this pam setting, I usually recommend 'Requires: pam >= 0.80'. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review