Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632858 Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(sagarun@xxxxxxxxx | |) --- Comment #6 from Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> 2010-11-12 13:11:00 EST --- #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [33%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** WAIT Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] Not sure this package is usable: - M-x slime-info does not work - the emacs-slime-init.el file is incorrect: inferior-lisp-program is seto to a path; should be a binary Ideally this really should be a drop-in replacement for someone who has swank installed from ELPA of course, I could just have the wrong set-up; could you describe how you configure Emacs? If there's anything non-standard it should probably be documented in a README.Fedora file ** FAIL source files match upstream Latest available snapshot is from Nov 12, MD5 sum: 7c155ea3ded179830baf58f232858e58 ** TODO License [2/3] *** DONE License is Fedora-approved *** FAIL License field accurate License should be "Public Domain and GPLv3+ and GPLv2+ and LLGPL"; please put a comment above the license field describing which files fall under which license: - default licensing is Public Domain (see README) - slime-autoloads is GPLv2+ (seriously, for such a small file *shakes head*) - swank-ccl is LLGPL - many files in contrib are GPL (same as Emacs). Meaning GPLv3+ *** DONE License included iff packaged by upstream However, please talk to upstream about bundling the license texts for GPLv3+ and LLGPL, rather than just refering to packages that contain them ** DONE rpmlint [2/2] *** DONE on src.rpm clean: $ rpmlint ../SRPMS/emacs-slime-1.2-2.fc13.20100930cvs.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. *** DONE on noarch.rpm $ rpmlint ~/Downloads/emacs-slime-1.2-2.fc14.20100930cvs.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ** TODO Language & locale [2/3] *** FAIL Spec in US English - State "FAIL" from "TODO" [2010-11-12 Fri 18:35] \\ Some issues: - summary: while I understand you don't want to overcapitalize everything and make it look like an advertisement, Lisp and Emacs should have their initial letters capitalized because they are proper nouns - version-release tags should be fixed. the latest snapshot is a pre-release of 3.0-alpha according to slime.info, so V-R should be 3.0-0.X.alpha.20101112cvs%{?dist} see http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results $ rpmlint ~/Downloads/emacs-slime-1.2-2.fc14.20100930cvs.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. *** DONE BRs complete *** DONE Directory ownership ** TODO Spec inspection [7/10] *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** WAIT no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting EPEL5]]) BuildRoot not necessary unless you plan to build for RHEL 5. Not fatal, though; ignore this *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** DONE Documentation [2/2] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review