[Bug 651123] Review Request: sarGraphs - Graphical System Usage Web Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651123

--- Comment #9 from Jeffrey Ness <jness@xxxxxxxxxxxxxxxx> 2010-11-09 15:53:13 EST ---
(In reply to comment #8)
> Hi Jeffrey
> 
> your rpmlint output gives you a few errors should be addressed:
> 
> - remove version info from your spec file name
> - your summary should be a single line something like - "A graphical PHP
> sysstat interface" whilst your description would go into a little more detail
> about exactly what it does
>  - you need to set your file attributes in the files section:
> 
> %files 
> %defattr(-,root,root,-)
> 
> 
> Also, 
> 
> - you are missing a trailing curly bracket in your %install section
> - remove the comment from your install section and change the last line to 
> %{__cp} -av *  %{buildroot}%{_datadir}/%{name}-%{version}
> - if you are upstream consider renaming to sargraphs
> 
> Anyway, hope that helps
> 
> Brendan

Thanks for the great information Brendan! It seems I may not of placed the
correct SPEC file at the URL mentioned above.

Below is my new rpmlint without errors or warnings:

$ rpmlint ../SRPMS/sarGraphs-1.1-1.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--

And a successful build on the Fedora Build System:

$ koji build --scratch dist-5E-epel
/usr/src/redhat/SRPMS/sarGraphs-1.1-1.src.rpm 
Uploading srpm: /usr/src/redhat/SRPMS/sarGraphs-1.1-1.src.rpm
[====================================] 100% 00:00:11   4.42 MiB 396.80 KiB/sec
Created task: 2591623
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2591623
Watching tasks (this may be safely interrupted)...
2591623 build (dist-5E-epel, sarGraphs-1.1-1.src.rpm): free
2591623 build (dist-5E-epel, sarGraphs-1.1-1.src.rpm): free -> open
(x86-01.phx2.fedoraproject.org)
  2591625 buildArch (sarGraphs-1.1-1.src.rpm, noarch): open
(x86-17.phx2.fedoraproject.org)
  2591625 buildArch (sarGraphs-1.1-1.src.rpm, noarch): open
(x86-17.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
2591623 build (dist-5E-epel, sarGraphs-1.1-1.src.rpm): open
(x86-01.phx2.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

2591623 build (dist-5E-epel, sarGraphs-1.1-1.src.rpm) completed successfully

--

Below are the links to the SRPM and SPEC:

Spec URL: http://flip-edesign.com/source/sarGraphs.spec
SRPM URL: http://flip-edesign.com/source/sarGraphs-1.1-1.src.rpm

--

Thanks for being patient and giving excellent advise!!

Jeffrey-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]