[Bug 651123] Review Request: sarGraphs - Graphical System Usage Web Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651123

Brendan Jones <brendan.jones.it@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|fedora@xxxxxxxxxxxxxx       |nobody@xxxxxxxxxxxxxxxxx

--- Comment #8 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2010-11-09 15:28:44 EST ---
Hi Jeffrey

your rpmlint output gives you a few errors should be addressed:

- remove version info from your spec file name
- your summary should be a single line something like - "A graphical PHP
sysstat interface" whilst your description would go into a little more detail
about exactly what it does
 - you need to set your file attributes in the files section:

%files 
%defattr(-,root,root,-)


Also, 

- you are missing a trailing curly bracket in your %install section
- remove the comment from your install section and change the last line to 
%{__cp} -av *  %{buildroot}%{_datadir}/%{name}-%{version}
- if you are upstream consider renaming to sargraphs

Anyway, hope that helps

Brendan

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]