Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527462 --- Comment #19 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-11-08 12:19:32 EST --- rpmlint output: gmpy.src: W: spelling-error %description -l en_US multiprecision -> multiprocessing, multiprocessor, imprecision gmpy.src: W: invalid-url Source0: http://gmpy.googlecode.com/files/gmpy-1.13.zip HTTP Error 404: Not Found gmpy.x86_64: W: spelling-error %description -l en_US multiprecision -> multiprocessing, multiprocessor, imprecision gmpy.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/gmpy.so gmpy.so()(64bit) gmpy.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/gmpy-1.13/test/test_large.py gmpy.x86_64: W: file-not-utf8 /usr/share/doc/gmpy-1.13/doc/gmpydoc.txt gmpy.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/gmpy.so 0775L 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Warnings 1-3 can be ignored. The rest will have to be tended to. First of all, the private-shared-object-provides warning means that RPM's automatic library provides mechanism is picking up the shared library as a Provides, which it should not do. Adding # we don't want to provide private python extension libs %{?filter_setup: %filter_provides_in %{python_sitearch}/.*\.so$ %filter_setup } to the beginning of the specfile should fix this issue. Warning 5 is caused by test/test_large.py containing DOS style line endings. One can fix this in the %prep phase using the trick at http://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings However, I'm not sure the test directory should be shipped at all. A better alternative is to run the tests in the build. You can do this by adding *** %check # Make python see the library that we have just compiled libdir=`ls build/|grep lib` export PYTHONPATH=`pwd`/build/$libdir cd test python gmpy_test.py *** to the spec file (without the ***, of course). Fix warning 6 with e.g. placing # Convert files to utf-8 for file in doc/gmpydoc.doc; do iconv -f ISO-8859-1 -t UTF-8 -o $file.new $file && \ touch -r $file $file.new && \ mv $file.new $file done in %prep, directly after %setup, as instructed in http://fedoraproject.org/wiki/PackagingTricks#Convert_encoding_to_UTF-8 And finally, the last warning can be fixed by running chmod 755 %{buildroot}%{python_sitearch}/gmpy.so at the end of %install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review